Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable tests skipped by #2811 #4246

Open
Deleplace opened this issue Jul 2, 2024 · 0 comments · May be fixed by #4247
Open

Re-enable tests skipped by #2811 #4246

Deleplace opened this issue Jul 2, 2024 · 0 comments · May be fixed by #4247
Assignees
@Deleplace
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Deleplace
Copy link
Contributor

Let's remove the 13 occurrences of

t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811")

and make sure the tests still pass.

See #2811 (closed 2023-04)
@Deleplace Deleplace added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. labels Jul 2, 2024
@Deleplace Deleplace self-assigned this Jul 2, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 2, 2024
Deleplace added a commit to Deleplace/fork-golang-samples that referenced this issue Jul 2, 2024
@Deleplace
fix(all): unskip 13 tests from issue GoogleCloudPlatform#2811
5facf36 
Fixes GoogleCloudPlatform#4246
This was referenced Jul 2, 2024
Draft
Merged
Deleplace added a commit to Deleplace/fork-golang-samples that referenced this issue Jul 3, 2024
@Deleplace
fix(batch): valid date format layout
e19db3e 
Part of GoogleCloudPlatform#4246
@Deleplace Deleplace mentioned this issue Jul 3, 2024
Merged
Deleplace added a commit that referenced this issue Jul 19, 2024
@Deleplace
fix(batch): valid date format layout (#4252)
eb1408f 
Part of #4246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Deleplace Deleplace

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(all): unskip 13 tests from issue #2811 Deleplace/fork-golang-samples
1 participant
@Deleplace