From 5facf36442743f85a895260554ad1839e27a6927 Mon Sep 17 00:00:00 2001 From: Valentin Deleplace Date: Tue, 2 Jul 2024 18:16:23 +0200 Subject: [PATCH] fix(all): unskip 13 tests from issue #2811 Fixes #4246 --- asset/quickstart/create-saved-query/main_test.go | 1 - asset/quickstart/delete-saved-query/main_test.go | 1 - asset/quickstart/export-assets/main_test.go | 1 - asset/quickstart/get-saved-query/main_test.go | 1 - asset/quickstart/list-saved-queries/main_test.go | 1 - asset/quickstart/update-saved-query/main_test.go | 1 - batch/create_with_gcs_bucket_test.go | 1 - batch/create_with_template_test.go | 1 - batch/job_basics_test.go | 2 -- bigquery/snippets/datatransfer/integration_test.go | 1 - iam/deny/deny_policy_test.go | 1 - translate/v3/translate_text_test.go | 1 - 12 files changed, 13 deletions(-) diff --git a/asset/quickstart/create-saved-query/main_test.go b/asset/quickstart/create-saved-query/main_test.go index 00e38081b1..77ba080184 100644 --- a/asset/quickstart/create-saved-query/main_test.go +++ b/asset/quickstart/create-saved-query/main_test.go @@ -64,7 +64,6 @@ func TestMain(m *testing.M) { } func TestCreateSavedQuery(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") buf := new(bytes.Buffer) err := createSavedQuery(buf, projectID, savedQueryID) if err != nil { diff --git a/asset/quickstart/delete-saved-query/main_test.go b/asset/quickstart/delete-saved-query/main_test.go index 5176ced697..a1d7b3e4b0 100644 --- a/asset/quickstart/delete-saved-query/main_test.go +++ b/asset/quickstart/delete-saved-query/main_test.go @@ -88,7 +88,6 @@ func TestMain(m *testing.M) { } func TestDeleteSavedQuery(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") buf := new(bytes.Buffer) err := deleteSavedQuery(buf, projectID, savedQueryID) if err != nil { diff --git a/asset/quickstart/export-assets/main_test.go b/asset/quickstart/export-assets/main_test.go index 15bacc0b5e..99cc4f2c2c 100644 --- a/asset/quickstart/export-assets/main_test.go +++ b/asset/quickstart/export-assets/main_test.go @@ -25,7 +25,6 @@ import ( ) func TestMain(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") tc := testutil.SystemTest(t) env := map[string]string{"GOOGLE_CLOUD_PROJECT": tc.ProjectID} diff --git a/asset/quickstart/get-saved-query/main_test.go b/asset/quickstart/get-saved-query/main_test.go index 15a33d3025..66ce019117 100644 --- a/asset/quickstart/get-saved-query/main_test.go +++ b/asset/quickstart/get-saved-query/main_test.go @@ -88,7 +88,6 @@ func TestMain(m *testing.M) { } func TestGetSavedQuery(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") buf := new(bytes.Buffer) get_err := getSavedQuery(buf, projectID, savedQueryID) diff --git a/asset/quickstart/list-saved-queries/main_test.go b/asset/quickstart/list-saved-queries/main_test.go index 4884f11c67..fc25331e17 100644 --- a/asset/quickstart/list-saved-queries/main_test.go +++ b/asset/quickstart/list-saved-queries/main_test.go @@ -88,7 +88,6 @@ func TestMain(m *testing.M) { } func TestListSavedQueries(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") buf := new(bytes.Buffer) list_saved_queries_err := listSavedQueries(buf, projectID) diff --git a/asset/quickstart/update-saved-query/main_test.go b/asset/quickstart/update-saved-query/main_test.go index d0b456b4d9..7c6df5383c 100644 --- a/asset/quickstart/update-saved-query/main_test.go +++ b/asset/quickstart/update-saved-query/main_test.go @@ -88,7 +88,6 @@ func TestMain(m *testing.M) { } func TestUpdateSavedQuery(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") buf := new(bytes.Buffer) newDescription := "This is a new description" update_err := updateSavedQuery(buf, projectID, savedQueryID, newDescription) diff --git a/batch/create_with_gcs_bucket_test.go b/batch/create_with_gcs_bucket_test.go index cc41c2be65..117419d081 100644 --- a/batch/create_with_gcs_bucket_test.go +++ b/batch/create_with_gcs_bucket_test.go @@ -27,7 +27,6 @@ import ( ) func TestCreateJobWithBucket(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") t.Parallel() var r *rand.Rand = rand.New( rand.NewSource(time.Now().UnixNano())) diff --git a/batch/create_with_template_test.go b/batch/create_with_template_test.go index 083aeaea71..30fdf566df 100644 --- a/batch/create_with_template_test.go +++ b/batch/create_with_template_test.go @@ -30,7 +30,6 @@ import ( ) func TestCreateJobWithTemplate(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") t.Parallel() var r *rand.Rand = rand.New( rand.NewSource(time.Now().UnixNano())) diff --git a/batch/job_basics_test.go b/batch/job_basics_test.go index 72277a19f4..b11c9cbdc2 100644 --- a/batch/job_basics_test.go +++ b/batch/job_basics_test.go @@ -26,7 +26,6 @@ import ( ) func TestBatchJobCRUD(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") t.Parallel() var r *rand.Rand = rand.New( rand.NewSource(time.Now().UnixNano())) @@ -101,7 +100,6 @@ func TestBatchJobCRUD(t *testing.T) { } func TestBatchContainerJob(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") t.Parallel() var r *rand.Rand = rand.New( rand.NewSource(time.Now().UnixNano())) diff --git a/bigquery/snippets/datatransfer/integration_test.go b/bigquery/snippets/datatransfer/integration_test.go index 4830e6bd54..e46cb5b74d 100644 --- a/bigquery/snippets/datatransfer/integration_test.go +++ b/bigquery/snippets/datatransfer/integration_test.go @@ -31,7 +31,6 @@ import ( ) func TestDataTransfer(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") tc := testutil.SystemTest(t) ctx := context.Background() diff --git a/iam/deny/deny_policy_test.go b/iam/deny/deny_policy_test.go index 8d29896023..0bc1b58c10 100644 --- a/iam/deny/deny_policy_test.go +++ b/iam/deny/deny_policy_test.go @@ -29,7 +29,6 @@ import ( ) func TestDenyPolicySnippets(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") tc := testutil.SystemTest(t) ctx := context.Background() var r *rand.Rand = rand.New( diff --git a/translate/v3/translate_text_test.go b/translate/v3/translate_text_test.go index af4a9cd43a..431acd76a7 100644 --- a/translate/v3/translate_text_test.go +++ b/translate/v3/translate_text_test.go @@ -23,7 +23,6 @@ import ( ) func TestTranslateText(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") tc := testutil.SystemTest(t) sourceLang := "en-US"