CSS fix for Preferences Dialog #2104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is added in order let the elements fill the space in the widget span row, this is indeed necessary here, because , the width is available in the dialog, but the elements are aligned to the start.
|
Resolved by 99cf8f0. |
|
@RounakJoshi09 Just to chime in about why I didn't merge this PR, unfortunately your proposed CSS change would have a large impact on many parts of the UI beyond just the misaligned settings dialog content. But I'm also going to quickly check if it would have made desirable improvements or if it broke things (just by looking at the code, I'm having to assume the latter is more likely, but I'll check by triggering a build real quick). |
|
!build |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is added in order let the elements fill the space in the widget span row, this is indeed necessary here, because , the width is available in the dialog, but the elements are aligned to the start, and not utilizing the width properly, in order to fix this in a responsive way, I have added the
justify-contentcss property, which uses the width available for theWidgetSpan.Fixes #2103
Screen shots after the fix
