You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The graph can fail to render due to a type error, or outright crash. If this happens while a user is interacting with WYSIWYG tooling (i.e. the graph isn't open), we should consider this a bug because the tooling broke the graph. In this situation, we should indicate to users that this situation isn't supposed to happen, and request they report the bug.
To prevent users from being prompted to report bugs arising from noodling around in the graph, even if they subsequently close the graph and Ctrl+Z their way back to the broken graph, we should store if the graph was open or closed during the document history snapshot. We could also open the graph for the user automatically if they undo/redo to a point when the graph was invalid and that node graph was open at that time. If so, it should also close the graph if the user undoes/redoes past that point and returns to a valid graph, without having interacted with the automatically-opened graph.
The text was updated successfully, but these errors were encountered:
@0HyperCube Yes, the tooling should detect that situation and react accordingly. In fact that's a bug for another reason too: the Rectangle node is a generator type node, meaning it has no primary input. The tooling is erroneously attaching a primary input to it anyways. We should probably make the API for attaching an input throw an error if it's attempting to connect a primary input to a node that doesn't accept one. If this was a Path node instead of a Rectangle node, which does accept a primary input, that wouldn't really be a bug but it would still be undesired tooling behavior in this situation. We'd want the tooling to detect you have a graphic attached directly to the artboard and wrap it in a layer so it can attach it to a layer which the new layer would become a sibling of.
The graph can fail to render due to a type error, or outright crash. If this happens while a user is interacting with WYSIWYG tooling (i.e. the graph isn't open), we should consider this a bug because the tooling broke the graph. In this situation, we should indicate to users that this situation isn't supposed to happen, and request they report the bug.
To prevent users from being prompted to report bugs arising from noodling around in the graph, even if they subsequently close the graph and Ctrl+Z their way back to the broken graph, we should store if the graph was open or closed during the document history snapshot. We could also open the graph for the user automatically if they undo/redo to a point when the graph was invalid and that node graph was open at that time. If so, it should also close the graph if the user undoes/redoes past that point and returns to a valid graph, without having interacted with the automatically-opened graph.
The text was updated successfully, but these errors were encountered: