Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ id causes more problems #24

Closed
kcmcleod opened this issue Jun 7, 2019 · 3 comments
Closed

@ id causes more problems #24

kcmcleod opened this issue Jun 7, 2019 · 3 comments
Labels
cant fix wontfix This will not be worked on

Comments

@kcmcleod
Copy link
Contributor

kcmcleod commented Jun 7, 2019

@ id is problem when it is missing as we have lots of blank nodes see #4
@ id is problem when Biosamples use the same value for every DataRecord see #22

ALSO @ id is problem with MINT as they assign both the DataCatalog and the nested Dataset the same @ id value; hence both Google & our scraper treat it as the same concept with unexpected results: [see GSDTT]{https://search.google.com/structured-data/testing-tool#url=https%3A%2F%2Fmint.bio.uniroma2.it}

  • Dataset is nested within DataCatalog, but the properties have been combined into a single concept which is both a DataCatalog & Dataset.
    • note my tool does not do this. Instead all properties are assigned to the DataCatalog and the Dataset just has a url.
  • As DataCatalog and Dataset both have a description the combined concept has 2 descriptions with the same values (they are not merged together because the DataCatalog description has an extra period, thus they are not identical).
    • They also both have the keywords, but this time the lists are truly identical so just 1 keywords property exists
@kcmcleod kcmcleod added the wontfix This will not be worked on label Jun 7, 2019
@kcmcleod
Copy link
Contributor Author

kcmcleod commented Jun 7, 2019

@AlasdairGray - nothing we can really do about this apart from improve training?!

@AlasdairGray
Copy link
Member

Improve training. Provide a proper validation tool. Inform people when we come across issues like this.

@AlasdairGray
Copy link
Member

@id property is now a minimal property in all profiles. Training has been added about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cant fix wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants