Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace button does not work #5

Open
olta opened this issue Mar 19, 2014 · 3 comments
Open

Replace button does not work #5

olta opened this issue Mar 19, 2014 · 3 comments

Comments

@olta
Copy link
Contributor

olta commented Mar 19, 2014

[Search] > [Replace] does not open the replace window.

@mmuman
Copy link
Member

mmuman commented Aug 1, 2014

Hmm the menu entry doesn't have the ellipsis, meaning it doesn't open a popup btw.

Interestingly, it does open it when the search string is not empty (ie. you did Search->Find, entered a string, and closed the popup).
And if the selection matches the search pattern it does replace it as intended instead of opening the popup...

@galexite
Copy link

I'm thinking that it should be best to use 'Find/Replace...' as the option in the menu because they both open up the Find dialog.

@pulkomandy
Copy link
Member

I don't think this is how it is supposed to work. The workflow would be:

  1. You open the Find dialog and select a string to find, and a string to replace
  2. You validate your choice, the dialog closes
  3. The first match for your "find" string is highlighted in the text view
  4. You can either "replace" it (using this menu item) or "find next".

If this is how it should actually work, the "Replace" item should only bring the dialog on the first time it is called. Or alternatively, it could be disabled until a search has been made from the Find dialog, and stay enabled only as long as there are matches for the last search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants