-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combos support #152
base: main
Are you sure you want to change the base?
Combos support #152
Conversation
Almost working, still not 100% |
I got a little bit busy recently, so I invited you as the repo member. Feel free to review and merge PRs when you want. :D |
Thank you so much! |
7c12e2f
to
256952c
Compare
8faa7b3
to
a7a6d51
Compare
|
Would you kindly consider my request #55 (Btw when I write "Chord" I mean "Combo") |
It seems that we need |
Well.. this is a soluton, we could then use it for |
Another possible solution is to add something like [rmk_main], replacing current [embassy_main]. Then we can add anything we want. |
Hi @pcasotti, I'm going to merge #250, which is a huge refactoring of the project. Before that, I'd like to merge this PR first, do you have time solving the conflicts? If you don't have time, you can just leave a comment here, I can help as well. As for the unfinished parts, I think we can record them in #117 |
Vial only supports combos up to 4 keys, if we have combos larger than that, we will hide them from vial
For now we will only store information supported by via and vial
I'll update the docs and then it's ready to merge |
Closes #117
COMBO_{ON/OFF/TOGGLE}
keycodescmb!
macro for easy combo declaration in rust