Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate gameplayFrames #4985

Open
briaguya-ai opened this issue Feb 2, 2025 · 0 comments
Open

investigate gameplayFrames #4985

briaguya-ai opened this issue Feb 2, 2025 · 0 comments

Comments

@briaguya-ai
Copy link
Contributor

we're setting/resetting gameplayFrames to 0 in a few places, it'd be good to get a better grasp on when/how that happened on original hardware and if there are situations where we need to set/reset it beyond those times

from #4984 (comment):

I know this is just copying what we had before, but I figure it's worth pointing out that this is not accurate to what it is actually happening: which is that this is resetting the frame count on any play destroy with the debug save loaded (title screen or LRZ).

I think the intent for the frame reset is to happen when ever we transition from a non-PlayState game state to a PlayState game state.

Not something we need to do in this PR, but should at least track an issue for investigation (e.g. test with hardware)

#4984 (comment) (reply):

yeah, i didn't want to go down the rabbit hole of that (and autosave stuff) when moving it over (it originally came from #1792, and there's more gameplayFrames stuff in #3389 too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant