Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[display] @:generic class is missing subclass statistics #9097

Open
Gama11 opened this issue Jan 18, 2020 · 3 comments · May be fixed by #11973
Open

[display] @:generic class is missing subclass statistics #9097

Gama11 opened this issue Jan 18, 2020 · 3 comments · May be fixed by #11973
Assignees
@Simn
Labels
feature-ide IDE / Editor support test-needed
Milestone
Later

Comments

@Gama11
Copy link
Member

Gama11 commented Jan 18, 2020

Here, A has one subclass as expected:

This info disappears once A is made @:generic (vshaxe only shows it if > 0):

Interestingly, "Go to Implementations" on A does work - I thought they use the same data under the hood?

class Main<T> {
	static function main() {}
}

@:generic class A<T> {}
class B extends A<String> {}
@Gama11 Gama11 added bug feature-ide IDE / Editor support labels Jan 18, 2020
@RealyUniqueName RealyUniqueName added this to the Release 4.1 milestone Jan 22, 2020
@Simn
Copy link
Member

Simn commented Feb 9, 2020

I think this happens because the generated A_String class has a position that matches the A<String> occurrence. It would be good to check the actual @statistics output for this.

@Simn Simn self-assigned this Feb 19, 2020
@Simn
Copy link
Member

Simn commented Apr 27, 2020

The "good" news is that now "Go to Implementations" doesn't work anymore either, so at least it's consistent.

Simn added a commit that referenced this issue Apr 29, 2020
@Simn
[typer] inherit name position to generic instances
86c5241 
see #9097
@Simn Simn added test-needed and removed bug labels Apr 29, 2020
@Simn Simn modified the milestones: Release 4.1, Backlog Apr 29, 2020
@Simn
Copy link
Member

Simn commented Apr 29, 2020

This works now, but it would be nice to have a test for it.

@Simn Simn modified the milestones: Backlog, Later Mar 24, 2023
kLabz added a commit that referenced this issue Feb 4, 2025
@kLabz
[tests] add test for #9097
aceefd7
@kLabz kLabz linked a pull request Feb 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simn Simn

Labels
feature-ide IDE / Editor support test-needed
Projects
None yet
Milestone
Later
Development

Successfully merging a pull request may close this issue.

[tests] add test for #9097 HaxeFoundation/haxe
3 participants
@Simn @Gama11 @RealyUniqueName