-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colRanks2()/rowRanks2(): As colRanks()rowRanks() where 'ties.method' has the same default as rank() #251
Comments
I think that would be a little confusing to the users as the only difference between the functions would be the default argument. Writing |
We can work with CRAN and Bioconductor packages to use explicit arguments, but I'm concerned about all existing scripts and dynamic reports that will silently give the wrong answer when changing the default. We have no way to notify those cases. |
Either way, we could make argument We could start out by giving a |
This is the strategy we decided on back in April 2024. This is tracked in #142. |
Updating the default for argument
ties.method
forrowRanks()
might be too risky for backward compatible reasons, cf. #142.It could be quicker to just introduce
rowRanks2()
that uses the same default.The text was updated successfully, but these errors were encountered: