Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to gymnasium in favor of openai gym #154

Merged
merged 9 commits into from
Feb 1, 2025
Merged

Switch to gymnasium in favor of openai gym #154

merged 9 commits into from
Feb 1, 2025

Conversation

itwasabhi
Copy link
Contributor

Description

Gymnasium's gym is a drop-in replacement of open-ai's gym. Some of these gymnasium modules were already being used in this repo as it depends on PettingZoo.

Fixes #152

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@itwasabhi
Switch to gymnasium in favor of openai gym.
de6e419 
Gymnasium's gym is a drop-in replacement of open-ai's gym. Some of these gymnasium modules were already being used in this repo as it depends on PettingZoo.
@micahcarroll
Copy link
Member

@itwasabhi, sadly these changes seem to have broken some of the tests relating to PettingZoo.

@itwasabhi
Copy link
Contributor Author

Yes -- will investigate and ping once ready!

@itwasabhi
Copy link
Contributor Author

@micahcarroll I'm seeing very similar test failures when running tests even before these changes (i.e. 9dfc1e8, cd6739e). Any clue as to why the automated workflow flag those? I dont think the changes here are causing any new test failures (aside from the formatting ones atm)

@itwasabhi
Copy link
Contributor Author

itwasabhi commented Dec 23, 2024 •
edited
Loading

To clarify, its the visualization_test.py that is (and has been) problematic as far as i can tell.

The petting zoo test seems fine when it try to repro:

overcooked_ai/testing$ python overcooked_test.py TestPettingZooEnvironment -v
test_api (__main__.TestPettingZooEnvironment) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.001s

@micahcarroll micahcarroll merged commit 8bbf72e into HumanCompatibleAI:master Feb 1, 2025
3 checks passed
@itwasabhi
Copy link
Contributor Author

Thanks for the fixes!

@itwasabhi itwasabhi deleted the update_to_gymnasium branch February 1, 2025 11:27
@micahcarroll
Copy link
Member

Thank you @itwasabhi! The repo is getting pretty old and it really would benefit from a revamp (e.g. switching to uv from conda, increasing the python version, etc.) 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Awkward gym dependencies
2 participants
@itwasabhi @micahcarroll