Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Preview Waiting for 1.4 #12

Closed
alfarok opened this issue Apr 17, 2017 · 6 comments
Closed

Background Preview Waiting for 1.4 #12

alfarok opened this issue Apr 17, 2017 · 6 comments
Assignees

Comments

@alfarok
Copy link
Contributor

alfarok commented Apr 17, 2017

Everything is in place to capture the background preview geometry image, but it was not added to Dynamo version 1.3.0 as expected so we have to wait for 1.4.0. In the meantime this functionality will work on dailybuilds (other issues could occur down the line though which doesn't make this a good option).

See this thread

@alfarok alfarok self-assigned this Apr 17, 2017
@alfarok
Copy link
Contributor Author

alfarok commented Apr 17, 2017

It may be worth looking into writing our own capture as we initially discussed because of the delay and we are still going to run into quality issue (discussed here) with the out-of-the-box capture tools on large definitions.

@schaggar16
Copy link

@alfarok i am very interested in the functionality of being able to capture the image of the background preview geometry image. Was very excited to see this functionality in 1.3 but alas wasn't to be.
is it possible to setup a node in one of the current stable dynamo builds to do this?

@alfarok
Copy link
Contributor Author

alfarok commented Apr 19, 2017

@schaggar16 There are 2 options if you want to capture the background preview before the 1.4.0 release. If you have to use a stable build such as 1.3.0 you would have to write your own capture function. Ian has already written this so you could just reference the existing logic and write a version that works in something like a zero touch/custom UI node. The other option would be to use a a daily build of dynamo and un-comment the OnRequestSave3DImage method here (but be aware the node isn't tested against new daily build implementations which may lead to unexpected crashes).

I have looked into the first option and while it is definitely possible I am not sure if it is worth putting something together that is inevitably going to be replaced in less than 6 months. That being said I think we are going to run into image quality issues on really large graphs so writing a new screen capture that uses some type of bitmap processing to stitch images together would be beneficial. I have't had the chance to sit down and dig into that yet but am hoping to soon.

Let me know if you have any other questions on the subject, but I hope this helps.

@schaggar16
Copy link

@alfarok thank you for the reply. While i do agree that the custom node would be abortive work, this is still a very useful function that i know i can put to use straight away. I do like the idea of having a node which can then be used to drive the further development - i guess just need a starting point. Would you be able post a link to Ian's work on this please?
in all honesty i haven't really got to grips with putting together zero touch/custom UI nodes, how much work do you reckon it is to implement Ians work into a custom node? even if there are image quality issues, it gives a platform to develop from.

@alfarok
Copy link
Contributor Author

alfarok commented Apr 19, 2017

@schaggar16 no problem, the link in the first post points to the pull request where you can look through the modified files. Most of them are UI related but you just need the method that actually captures the geometry. I think the most challenging part is going to be making sure the canvas for the bitmap capture is set exclusively as the background preview to ensure you are only copying that single window. I am guessing the background preview is passed as a parameter somewhere in the method to accomplish this.

It may be a bit challenging for a first custom node project but I would check out this wiki (Zero Touch Plugin Development) as a starting point

@alfarok
Copy link
Contributor Author

alfarok commented Mar 4, 2018

Background preview available in Dynamo Core v2.0. This feature has been implemented into the node in #16

@alfarok alfarok closed this as completed Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants