Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScenarioManager - Review and cleanup code around add_file_as_data_asset #37

Open
victorterpstra opened this issue Jan 21, 2022 · 0 comments

Comments

@victorterpstra
Copy link
Collaborator

Review the code in the ScenarioManager around registering a file as an asset in CPD.
Over the lifetime of DSX/ICPd/CPP/CPDaaS the necessary steps and APIs have been changing.
There have been major fixes, but there is deprecated code that is confusing.

Potential problem:
In the past, most methods around this topic have been static and could have been called directly.
Given that CPDaaS requires the project, is was getting harder to keep maintaining static methods.
Code cleanup may cause backward incompatibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant