Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROD] Skip non-working endpoints in NS_INITIATIVES #2277

Open
szabozoltan69 opened this issue Oct 1, 2024 · 1 comment
Open

[PROD] Skip non-working endpoints in NS_INITIATIVES #2277

szabozoltan69 opened this issue Oct 1, 2024 · 1 comment
Assignees
@szabozoltan69
Labels
bug

Comments

@szabozoltan69
Copy link
Contributor

Issue

Recently in https://github.com/IFRCGo/go-api/blob/develop/api/management/commands/ingest_ns_initiatives.py#L22-L24 we collect 3 data-api.ifrc.org endpoint results. If one of them is erroneous (like recently, when CBF gives error 500), the whole job fails due to the united results in all_fund_data.

The suggestion is: let's check the sanity of the results before uniting them.
@szabozoltan69 szabozoltan69 mentioned this issue Oct 1, 2024
Merged
@tovari tovari added the bug label Oct 1, 2024
@szabozoltan69
Copy link
Contributor Author

Deployed to Staging

@szabozoltan69 szabozoltan69 assigned tovari and szabozoltan69 and unassigned susilnem and tovari Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szabozoltan69 szabozoltan69

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@szabozoltan69 @susilnem @tovari