Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPICE - Error in computing filename date string in write_cdf #1208

Open
subagonsouth opened this issue Dec 6, 2024 · 0 comments
Open

SPICE - Error in computing filename date string in write_cdf #1208

subagonsouth opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
SPICE Related to SPICE

Comments

@subagonsouth
Copy link
Contributor

Algorithm Description:

While working on SPICE time functions, I discovered that the implementation in imap_processing/cdf/utils.py::write_cdf for generating the date string from the zeroth element of the Dataset epoch coordinate is incorrect by 5 seconds due to the occurrences of 5 leap-seconds since the J2000 epoch. This ticket it to evaluate and figure out a solution. Ideas:

  • Hard code 5 second offset into calculation. The advantage of doing it this was is that writing the CDF will not require any SPICE kernels be furnished. The disadvantage is that it will be wrong if/when another leap-second occurs.
  • Use SPICE. The advantage is it will always be correct assuming the correct leap-second kernel is furnished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SPICE Related to SPICE
Projects
Status: No status
Development

No branches or pull requests

1 participant