Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve 2 issues #225

Closed
wants to merge 4 commits into from
Closed

Resolve 2 issues #225

wants to merge 4 commits into from

Conversation

Kej-r03
Copy link
Contributor

@Kej-r03 Kej-r03 commented Apr 23, 2022

Fix #197
The change in event_item.html was just a sample change.
The left margin has been added in header.css file.

Fix #212
Add title attribute inside iframe tag.

Yavnikaa
Yavnikaa reviewed May 3, 2022
View reviewed changes
Copy link
Member

@Yavnikaa Yavnikaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This css should be changed in the menu file, and not in the header.

Yavnikaa
Yavnikaa reviewed May 3, 2022
View reviewed changes
Copy link
Member

@Yavnikaa Yavnikaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chage in event-item.html test file is not required.

@Yavnikaa
Copy link
Member

@Kej-r03 jaldi karde changes please. We'll merge it then!

@ParitoshKabra
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yavnikaa Yavnikaa Yavnikaa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title element missing in iframe Left margin for hamburger
3 participants
@Kej-r03 @Yavnikaa @ParitoshKabra