Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide guidance on running SQL upgrade scripts and do a little reorg #5189

Merged
merged 4 commits into from
Oct 19, 2018

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Oct 15, 2018

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

This script is referenced from
https://github.com/IQSS/dataverse/releases/tag/v4.8 and it's unclear
why it was not part of upgrade_v4.7.1_to_v4.8.sql

New contributors have found the presence of this script in the
"scripts/database" directory confusing and have assumed that the process
they should follow is to create a similar script, not knowing about our
upgrade_v4.7.1_to_v4.8.sql process.
@pdurbin pdurbin changed the title 5186 - moving required db changes to main upgrade script provide guidance on running SQL upgrade scripts and do a little reorg Oct 16, 2018
@coveralls
Copy link

coveralls commented Oct 16, 2018

Coverage Status

Coverage increased (+0.08%) to 15.689% when pulling e39a94d on QualitativeDataRepository:5186-PSQLException into e948af2 on IQSS:develop.

Copy link
Contributor

@matthew-a-dunlap matthew-a-dunlap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Much needed.

@kcondon kcondon merged commit bd777a3 into IQSS:develop Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants