Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade command breaks scheduler "add task" form #4

Open
mp-sschreiber opened this issue Nov 5, 2020 · 2 comments
Open

Upgrade command breaks scheduler "add task" form #4

mp-sschreiber opened this issue Nov 5, 2020 · 2 comments

Comments

@mp-sschreiber
Copy link

TYPO3 version: 10.4.9 (composer)

I'm getting the following error when trying to create a new scheduler task:

TypeError
strpos() expects parameter 1 to be string, null given

in /var/www/html/vendor/helhum/typo3-console/Classes/Console/Mvc/Cli/CommandDispatcher.php line 95

It seems that your UpgradeCommand needs a cli environment to be loaded correctly as it calls CommandDispatcher::createFromCommandRun() in its constructor, leading to the error above in non-cli.

To clarify, I did not try to add your command as a scheduler task. The error happens once you open the form to add new tasks. Maybe just exclude it from scheduler?

@helhum
Copy link

helhum commented Jan 21, 2021

CommandDispatcher must not be instantiated in contructor to avoid this error to happen.
The command should also be marked not schedulable in addition, just to be sure to avoid confusion.

@IchHabRecht
Copy link
Owner

Hi @mp-sschreiber,

The problem should be solved with the latest release of core_upgrader 1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants