Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the display_name instead of the name of the object in the output of the tree #55

Closed
gbin2265 opened this issue Jun 16, 2024 · 7 comments · Fixed by #57
Closed

Use the display_name instead of the name of the object in the output of the tree #55

gbin2265 opened this issue Jun 16, 2024 · 7 comments · Fixed by #57
Assignees
Milestone

Comments

@gbin2265
Copy link

Hello,

Thank you @martialblog for making this module compatible with IcingaDB.
For me, this module also has its value.

Is it possible to use the display name instead of the name (object name) when viewing the tree ?

Name : redhat_linux_127_0_0_2 -> This is what is stated in the YAML file and is currently used in the output
Display Name : server127.dns.com -> This is the friendly name, to be used in the output if possible.

Perhaps you could provide a parameter in the YAML to make this switch?
Or a global parameter in the config file of the module.

regards,
Geert

@martialblog
Copy link
Member

Hi, thanks for the feedback. Wasn't sure anyone still uses this module.

Should be possible to use the display name, I'll have a look at it.

Regards,
Markus

@martialblog martialblog added this to the 0.4.0 milestone Jun 17, 2024
@martialblog martialblog self-assigned this Jun 17, 2024
@martialblog
Copy link
Member

@gbin2265 Hi, if you want you can check this branch out: #57

I think a good solution is to use the display_name if set on an object, as the name implies it is used for displaying.

Feedback is welcome

@gbin2265
Copy link
Author

Thank you for the modifications.

This is much more readable because we use names like host_linux_192_168_001_001 and display names like home.dns.com.

However, could it be that it only works for a HOST or HOSTGROUP, but not for a HOST in combination with a SERVICE?
In that case, the object name is still used instead of the display name.

regards,
Geert

@martialblog
Copy link
Member

Thanks for the feedback! I'll have a look at it.

@martialblog
Copy link
Member

I fixed it on the fix/displaynames branch

@gbin2265
Copy link
Author

I have tested the modification and it works.
Thank you!

@martialblog
Copy link
Member

Perfect. This will make it into the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants