-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exterior elements is empty #18
Comments
Most likely, it's not empty, but it doesn't contain the spatial hierarchy to connect the elements to the project so some viewers will not show anything. A more versatile approach is to use export_json instead and use ifcopenshell's IfcPatch ExtractElements recipe on the resulting elements from the JSON. ExtractElements will copy over the full hierarchy. CI/CD builds are being worked on. Soon you can just install this from using python pip. |
Hi, aothms. |
Probably the inclusion criteria need to be tweaked. The full list of available arguments to the function is here: Line 1273 in ae3735d
These factors and face counts are an attempt at preventing situations like this where the gray element would be counted as external due to the voxel resolution.
Not all viewers have the requirement to have a fully connected spatial decomposition tree. The model from export_ifc is not really invalid, it's just that the elements are not really part of the project and viewers choose to handle that differently. |
Hello, I am having a problem running the code you provided.
The code is as:
file = parse("duplex.ifc")
surfaces = create_geometry(file)
voxels = voxelize(surfaces)
external = exterior(voxels)
shell = offset(external)
export_ifc(file, shell, surfaces, "exterior.ifc")
My operating system is Windows.
![image](https://private-user-images.githubusercontent.com/49013144/397651757-765db369-4447-4072-b6f1-6c5c4f6c9027.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MzM5MjIsIm5iZiI6MTczOTkzMzYyMiwicGF0aCI6Ii80OTAxMzE0NC8zOTc2NTE3NTctNzY1ZGIzNjktNDQ0Ny00MDcyLWI2ZjEtNmM1YzRmNmM5MDI3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDAyNTM0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAzNTUwODhiODUwNjkwMDgwOGNiNzI2YzA4MGYzODJkNzAzZDgzMmU5MmMwZTI4YTM2OTFlM2U4NGYzMzMyMGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.PJpbi7HhbIOOCByoLtFAb1-8o44QQxIIJWPzlJYp4So)
Due to the lack of corresponding DLLs in the exe provided by conda, I downloaded the exe from here (https://github.com/IfcOpenShell/voxelization_toolkit/releases/tag/v0.3.0).
I test sample data (duplex.ifc).
The result is that "exterior.ifc" is empty.
Can you provide other versions of exe that can be used for Windows? Thank you very much. Looking forward to your reply.
The text was updated successfully, but these errors were encountered: