From 26ee835c2b2fe66903ae173e4418bfb396cf733e Mon Sep 17 00:00:00 2001 From: Murray Stevenson <50844517+murraystevenson@users.noreply.github.com> Date: Fri, 5 Jul 2024 09:30:34 -0700 Subject: [PATCH 1/2] CI : Continue using Node16 for actions Actions are now run on Node20 by default, but this requires glibc >=2.28 so actions no longer run in our CentOS 7 build container. Setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true allows us to continue using Node16 for the near future, but support for this may be removed in October... https://github.blog/changelog/2024-05-17-updated-dates-for-actions-runner-using-node20-instead-of-node16-by-default/ --- .github/workflows/main.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 67e2f0b2dd..7bff3a8d13 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -86,6 +86,12 @@ jobs: container: ${{ matrix.containerImage }} + env: + # GitHub have moved to running actions on Node20, which prevents them from + # running on CentOS 7. The below allows actions to continue running on Node16 + # until October. + ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true + steps: - uses: actions/checkout@v2 From e320d1bfeac75248d801f15e1a3a4eb9ac0efde3 Mon Sep 17 00:00:00 2001 From: Murray Stevenson <50844517+murraystevenson@users.noreply.github.com> Date: Fri, 5 Jul 2024 09:37:35 -0700 Subject: [PATCH 2/2] CI : Update Node12 actions This matches the action versions used on Gaffer CI and silences the "The following actions uses node12 which is deprecated and will be forced to run on node16" warnings. There are even newer versions of these actions, such as checkout and upload-artifact v4, but they require Node20 which we're unable to use on our CentOS 7 build container. --- .github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7bff3a8d13..7482cd07b6 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -94,9 +94,9 @@ jobs: steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - - uses: ilammy/msvc-dev-cmd@v1.10.0 + - uses: ilammy/msvc-dev-cmd@v1.12.1 with: sdk: 10.0.17763.0 @@ -188,7 +188,7 @@ jobs: ${{ env.PACKAGE_COMMAND }} ${{ env.CORTEX_BUILD_NAME }}.${{env.PACKAGE_EXTENSION}} ${{ env.CORTEX_BUILD_NAME }} if: matrix.publish - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 with: name: ${{ env.CORTEX_BUILD_NAME }} path: ${{ env.CORTEX_BUILD_NAME }}.${{ env.PACKAGE_EXTENSION }}