Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write header and data using same file object #28

Open
alexdewar opened this issue Jan 5, 2023 · 0 comments
Open

Write header and data using same file object #28

alexdewar opened this issue Jan 5, 2023 · 0 comments
Labels
complex enhancement New feature or request
Milestone

Comments

@alexdewar
Copy link
Contributor

alexdewar commented Jan 5, 2023

Currently a call to write() entails the following:

  • Open file, write header, close file
  • Open file, write data, close file

It'd be cleaner to just open the file once and pass this file object to the various write*() functions. This will bring a (likely minuscule) performance benefit, but the main reason to do it is just to make the code clearer.

@dalonsoa dalonsoa added the enhancement New feature or request label Feb 10, 2023
@dalonsoa dalonsoa added this to the v1.1.0 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complex enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants