Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nationals role differs for Regional Series vs National Point Series #258

Open
djmolny opened this issue Oct 16, 2023 · 1 comment
Open
Assignees
Labels

Comments

@djmolny
Copy link
Collaborator

djmolny commented Oct 16, 2023

P&P 226 (Regional Series) states that Nationals results are a wildcard that can be applied to any region. P&P 227 (National Point Series) states that Nationals count towards the region in which they are held. Therefore, IACCDB must know which contests (Power & Glider) are Nationals and the region in which Nationals is held.

The IAC website's list of regions includes National, and IACCDB uses that value to treat Nationals as a wildcard per P&P 226. However, that will screw up the National Point Series calculations (once that they are automated).

@djmolny djmolny added the bug label Oct 16, 2023
@djmolny djmolny self-assigned this Oct 16, 2023
@djmolny
Copy link
Collaborator Author

djmolny commented Oct 16, 2023

Tentative solution:

  • Add a Contest#special_type' attribute to IACCDB, mirroring Drupal's Contest` field of the same name
  • When calculating the Regional Series, the logic should use Contest#special_type to determine if the wildcard rule applies
  • When calculating the National Point Series, use the Contest#region attribute as usual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant