Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was there a version 0.96? #72

Open
KeithBrio opened this issue Sep 19, 2024 · 2 comments
Open

Was there a version 0.96? #72

KeithBrio opened this issue Sep 19, 2024 · 2 comments

Comments

@KeithBrio
Copy link

I am in the midst of updating and migrating a very old project to .NET 6 and beyond. It is using version 0.96 of Irony, which I cannot find any record of on the internet (which is a concern).

However, when I upgrade, it complains that the Parent field being used on ParseTreeNode does not exist. Looking through the various GitHub repositories of Irony, I can’t find any record of this field ever existing.

Having a peek, I can see that ParseTreeNode.ParentNode was being set within the GetResultNode method in the ReduceParserAction class.

Does anyone have any knowledge of this field ever existing? Did the previous developers just roll their own and forget to document it?

@rivantsov
Copy link
Contributor

Hi,
can't say for sure what happened at these old times. I would just recommend to move to latest version (it is quite stable, nothing changed for years), and figure out all necessary changes, by try/fail/try again -succeed process. It's not worth investigating how this change happened in Irony, just modify the code to most likely alternative - I bet the ParentNode is a replacement/rename. in the end, it should all work. Good luck.

@KeithBrio
Copy link
Author

Thank you for the response.

There is a secondary activity to merge two parts of our code base that use Irony to the same code path and can see one does not use this enigmatic field but is achieving loosely the same results so will have to perform this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants