Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the gradient descent #2

Open
queqichao opened this issue Mar 20, 2015 · 2 comments
Open

About the gradient descent #2

queqichao opened this issue Mar 20, 2015 · 2 comments

Comments

@queqichao
Copy link

Hi, I think your code is very useful. But 'l-bfgs' seems to out perform 'sgd' consistently, which seems counter-intuitive to me. One thing I have in my mind is for 'sgd' it does not include the momentum to accumulate the past gradients. I would like to add that into your code and maybe try to merge it to your code. Is that ok to you?

@IssamLaradji
Copy link
Owner

Hi @queqichao , l-bfgs uses the hessian (the second derivative) to compute the direction to which the parameters update. It uses more information about the function than SGD for the update, so intuitively it makes sense that l-bfgs performs better in general.

I implemented one for scikit-learn and I believe it would be better if you could help Andy complete the finishing touches here (scikit-learn/scikit-learn#3939) :).

Thanks!! :)

@queqichao
Copy link
Author

Thanks for pointing out it. They seems to have added the function I am interested. Hope it to be release soon.

About the l-bfgs and sgd, actually I feel that l-bfgs is prone to converge to a local minimum quickly, while a properly tuned sgd could converge to a better model than l-bfgs in many case. Of course in theory there's no any guarantee about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants