Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search for pronouns in field values, names and the bio #72

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Search for pronouns in field values, names and the bio #72

wants to merge 8 commits into from

Conversation

nachtjasmin
Copy link
Contributor

@nachtjasmin nachtjasmin commented Jul 25, 2023 •
edited
Loading

The old approach was refactored. With this PR we are applying all searches to each individual field, including their name and value. This approach is optimized for speed in that regard, that we do the API calls as the last step.

I also embedded a list of all known pronoun.page pronouns, which can be generated using node scripts/generateKnownPronouns.mjs. The current state is commited to the repository and could be regenerated at any time.

A lot of the cases mentioned in #63 are going to be closed with this PR.

@nachtjasmin nachtjasmin linked an issue Jul 25, 2023 that may be closed by this pull request
Search for pronouns.page link in all fields #61
Open
@ItsVipra
Copy link
Owner

ItsVipra commented Aug 1, 2023

With all the new pronouns from all languages we get false positives, such as "I" for https://botsin.space/@lesbianBot.

Also logging could be a bit improved - the addon doesn't output any info after fetching a status

@nachtjasmin nachtjasmin force-pushed the 61-search-for-pronounspage-link-in-all-fields branch from 87aef3e to abcbadb Compare August 1, 2023 13:53
nachtjasmin and others added 7 commits August 14, 2023 13:57
@nachtjasmin
Search for pronouns in field values, names and the bio
48acb49 
The old approach was refactored. With this commit we are applying all
searches to each individual field, including their name and value. This
approach is optimized for speed in that regard, that we do the API calls
as the last step.
@nachtjasmin
Improve pronoun extraction for multiple definitions
af53085
@nachtjasmin
Add comprehensive list of all known pronouns
1b3a7ae
@nachtjasmin
Cover one more case with comma-separated pronouns
81b3684
@ItsVipra @nachtjasmin
only match words seperated by slash
075d6cc 
too many false positives for comma
@ItsVipra @nachtjasmin
search for explicit pronoun declarations first
0ad785e
@ItsVipra @nachtjasmin
add a bunch of debug statements
907405d
@nachtjasmin nachtjasmin force-pushed the 61-search-for-pronounspage-link-in-all-fields branch from 71bb62e to 907405d Compare August 14, 2023 12:13
@nachtjasmin
Copy link
Contributor Author

Although it looks fine to me, I won't merge it unless I've fixed the following problem:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'webextension-polyfill' imported from /home/jasmin/repos/protoots/src/libs/settings.js
    at new NodeError (node:internal/errors:399:5)
    at packageResolve (node:internal/modules/esm/resolve:889:9)
    at moduleResolve (node:internal/modules/esm/resolve:938:20)
    at defaultResolve (node:internal/modules/esm/resolve:1153:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:838:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:77:40)
    at link (node:internal/modules/esm/module_job:76:36)

@nachtjasmin nachtjasmin marked this pull request as draft August 24, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsVipra ItsVipra Awaiting requested review from ItsVipra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search for pronouns.page link in all fields
2 participants
@nachtjasmin @ItsVipra