Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

[Feature request] Remove dependence on bower #24

Open
brisc opened this issue Jun 16, 2017 · 9 comments
Open

[Feature request] Remove dependence on bower #24

brisc opened this issue Jun 16, 2017 · 9 comments

Comments

@brisc
Copy link

brisc commented Jun 16, 2017

Since Bower is deprecated in favor of npm/yarn, it'd be nice if this addon could put its video.js dependency into package.json instead of bower.json.

See also:

@thilinadinith
Copy link

can you please remove the bower dependencies ?

@Mifrill
Copy link

Mifrill commented Oct 12, 2020

any update on this?

@Mifrill
Copy link

Mifrill commented Oct 12, 2020

Hello, @omghax , are you able to release the recent master changes?
this commit is allow to get rid of the bower dependency, so, can you please?

@Mifrill
Copy link

Mifrill commented Nov 5, 2020

Hello, @nbibler , @nickawalsh are you able to release the current master branch code please to resolve this issue?

@nbibler
Copy link
Member

nbibler commented Nov 5, 2020

@Mifrill: Normally, I would say sure... but it seems bad to me that the commit you referenced is both the most recent commit in the main branch and failed to pass the test suite. Presumably, releasing that would release known-broken code which seems bad.

Generally, we just don't use ivy-videojs in any of our projects anymore which is why this library has stagnated. Instead, we just use video.js, directly, wrapped in application-specific video components.

@Mifrill
Copy link

Mifrill commented Nov 5, 2020

@nbibler but looks like, the failed build is not related to the last changes. it also broke in the current released version 0.6.6:
0bb2e15
same test:
https://travis-ci.org/github/IvyApp/ivy-videojs/jobs/221119314

not ok 15 Firefox 31.0 - Integration | Component | ivy-videojs-player: it sends a "play" action when played via the player API
    ---
        actual: >
            null
        message: >
            Test timed out
        Log: |

so, it, probably, intermittent test failures. Maybe @omghax may shed some light on it?
📓 https://travis-ci.org/github/IvyApp/ivy-videojs/jobs/513241557

not ok 13 Chrome 73.0 - [60045 ms] - Integration | Component | ivy-videojs-player: it sends a "play" action when played via the player API
    ---
        actual: >
            null
        stack: >
                at http://localhost:7357/assets/test-support.js:4921:7
        message: >
            Test took longer than 60000ms; test timed out.
        negative: >
            false
        Log: |
    ...

@Mifrill
Copy link

Mifrill commented Nov 5, 2020

@nbibler About:

Instead, we just use video.js, directly, wrapped in application-specific video components.

yeah, it's nice to remove this wrapper, I think, will appreciate if you able to share your implementation of the video-component with direct video.js usage, please 🙏

@nbibler
Copy link
Member

nbibler commented Nov 5, 2020

I haven't tested it or played with it, so there are probably some issues (specifically around component reuse if the model changes and updating the player src). I just threw together a rough skeleton of Video.js w/ a traditional Ember component (using TypeScript) which can be found here.

@Mifrill
Copy link

Mifrill commented Nov 5, 2020

@nbibler thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants