-
Notifications
You must be signed in to change notification settings - Fork 27
[Feature request] Remove dependence on bower #24
Comments
can you please remove the bower dependencies ? |
any update on this? |
Hello, @omghax , are you able to release the recent master changes? |
Hello, @nbibler , @nickawalsh are you able to release the current master branch code please to resolve this issue? |
@Mifrill: Normally, I would say sure... but it seems bad to me that the commit you referenced is both the most recent commit in the main branch and failed to pass the test suite. Presumably, releasing that would release known-broken code which seems bad. Generally, we just don't use ivy-videojs in any of our projects anymore which is why this library has stagnated. Instead, we just use video.js, directly, wrapped in application-specific video components. |
@nbibler but looks like, the failed build is not related to the last changes. it also broke in the current released version 0.6.6:
so, it, probably, intermittent test failures. Maybe @omghax may shed some light on it?
|
@nbibler About:
yeah, it's nice to remove this wrapper, I think, will appreciate if you able to share your implementation of the video-component with direct video.js usage, please 🙏 |
I haven't tested it or played with it, so there are probably some issues (specifically around component reuse if the model changes and updating the player src). I just threw together a rough skeleton of Video.js w/ a traditional Ember component (using TypeScript) which can be found here. |
@nbibler thank you! |
Since Bower is deprecated in favor of npm/yarn, it'd be nice if this addon could put its video.js dependency into package.json instead of bower.json.
See also:
The text was updated successfully, but these errors were encountered: