Upgrade all the things #28
Conversation
|
Sorry for the delays with this... This is now pretty solid and ready for review / consideration. |
|
Is there any chance that this PR is going to be merged in the near future? |
|
If anyone is interested, I've also created two very light shim libraries for videojs-contrib-hls and videojs-contrib-dash https://github.com/mwisner/ember-videojs-dash While not specifically tied to this addon in anyway, they do end up working for the ivy-videojs provided components. |
|
Hi @omghax, With this PR being open for a while now, i'm just curious if you or any of the other members from IvyApp have any feedback? I've been using this for sometime now on our product and haven't ran into any issues. |
|
Any update on this? I've also been using the forked version and it's been working great 👍 |
|
Hi - I get this error on Ember 3.1 & Fastboot: Could not find module |
|
Any movement on this PR? |
|
Hi @lougreenwood unfortunately I am not sure when I will have time to look into fixing the issues you describe. I am also not sure what the overall status is of this PR in terms of how the maintainers feel about it. I would prefer to hear from the maintainers regarding if this is the right direction or if another direction should be taken. Best Regards, |
This PR updates and tweaks a few things. However it's mostly focused on two major efforts:
Upgrade all dependencies and project to latest ember version(s)
This includes things like replacing jshint with eslint, upgrading packages used by dummy application (ember-bootstrap) and finally any "core" packages. Also dropped support for Ember 1.13.
In an effort to drop support for bower I also un-DRY'ed some of the tests. The library that was originally used for that is a bit outdated at this point and requires bower. If anyone has any recommendations to improve this I'd be happy to fix it.
Remove inclusion of videojs and use shim library
Doing so allows this package to focus specifically on videojs within ember. It also allows ivy-videojs to drop bower.
This change was inspired by the relationship between:
https://github.com/stefanpenner/ember-moment
https://github.com/jasonmit/ember-cli-moment-shim
Shim Library used:
https://github.com/joshuairl/ember-cli-videojs-shim.
closes #25
closes #24