You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After retrying the maximum amount of times specified, the library adds it's own error to the error list before returning which states the wait time and the maximum number of retries allowed.
For example in where it is used in this app github.com/j7mbo/palmago-streetview, here's what we get when trying to connect to elastic search on running the app for the first time with no elasticsearch connection:
* Head http://localhost:9200/palmago: dial tcp [::1]:9200: connect: connection refused
* Head http://localhost:9200/palmago: dial tcp [::1]:9200: connect: connection refused
* Head http://localhost:9200/palmago: dial tcp [::1]:9200: connect: connection refused
* Tried calling: 'func() error' 1000000000 times but reached max retries of: 3
I'm pretty damned sure I don't have 1000000000 in my configuration somewhere!
Expected Output
Change the error message so that it says something like:
Tried calling: 'func() error' after waiting for 5 seconds but reached max retries of: 3
Ensure the time is formatted correctly to only be in seconds as this is human readable.
Testing
Ensure you add a test that proves this is working. Easiest thing to do would be to check for two numbers in the error message and assert they are what you expect.
I'm here to help so feel free to ask!
The text was updated successfully, but these errors were encountered:
J7mbo
changed the title
Final error message from retrier displays incorrect call count
Final error message from retrier displays wait time with wrong text
Apr 27, 2019
Background
After retrying the maximum amount of times specified, the library adds it's own error to the error list before returning which states the wait time and the maximum number of retries allowed.
For example in where it is used in this app github.com/j7mbo/palmago-streetview, here's what we get when trying to connect to elastic search on running the app for the first time with no elasticsearch connection:
I'm pretty damned sure I don't have 1000000000 in my configuration somewhere!
Expected Output
Change the error message so that it says something like:
Ensure the time is formatted correctly to only be in seconds as this is human readable.
Testing
Ensure you add a test that proves this is working. Easiest thing to do would be to check for two numbers in the error message and assert they are what you expect.
I'm here to help so feel free to ask!
The text was updated successfully, but these errors were encountered: