Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing WinSock 2 from SoftGPU undoes patches from patcher9x #114

Open
YonicDev opened this issue Nov 5, 2024 · 2 comments
Open

Installing WinSock 2 from SoftGPU undoes patches from patcher9x #114

YonicDev opened this issue Nov 5, 2024 · 2 comments

Comments

@YonicDev
Copy link

YonicDev commented Nov 5, 2024

  • Guest OS: Windows 95 (patched with patcher9x)
  • SoftGPU Version: v0.6.2024.40-alpha3
  • VirtualBox version: 7.0.10 r158379
  • Host OS: Windows 10 x64 22H2 build 19045.5011
  • Display drivers: VBoxVGA, VBoxSVGA, VMWare SVGA-II

When enabling to install WS2 in the SoftGPU installer in a Windows 95 installation with patcher9x applied, it applies an unpatched version of NDIS.VXD, causing protection errors upon rebooting until patch9x is applied once again.

This is probably not correct as reapplying the patch may overwrite changes made by WS2, and upon reapplying it several applications using network interfaces freeze the system or stop working.

@YonicDev YonicDev changed the title Installing WinSock 2 undoes patches from patch9x Installing WinSock 2 from SoftGPU undoes patches from patch9x Nov 5, 2024
@YonicDev YonicDev changed the title Installing WinSock 2 from SoftGPU undoes patches from patch9x Installing WinSock 2 from SoftGPU undoes patches from patcher9x Nov 5, 2024
@nanitaro
Copy link

nanitaro commented Nov 5, 2024

In principle, there should be no problem.
Did you encounter a problem?

Patcher9x will only rewrite and insert at the specific point where the problem exists.
Also, the rewrite targets correspond to several variants.
This is explained in the patcher9x documentation.
https://github.com/JHRobotics/patcher9x?tab=readme-ov-file#cpu-speed-limit-bug-patching

If you have a problem, it is a bug in patcher9x.
Please report it in the patcher9x repository.

@YonicDev
Copy link
Author

YonicDev commented Nov 7, 2024

It might be possible that the NDIS variant is incorrectly identified by patcher9x when WS2 is installed, but I still believe that SoftGPU should at the very least inform the user to reboot, wait for the general protection error, reboot again and reapply patcher9x if it's been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants