Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMP Error Version 1 and 2 are not supported correctly #6

Closed
JPHutchins opened this issue Feb 12, 2024 · 1 comment · Fixed by #21
Closed

SMP Error Version 1 and 2 are not supported correctly #6

JPHutchins opened this issue Feb 12, 2024 · 1 comment · Fixed by #21
Labels
bug Something isn't working

Comments

@JPHutchins
Copy link
Owner

See discussion here: #3 (comment)

If the response is SMP Version 1 then the enums are mcumgr_err_t. If it's SMP Version 2 then the current implementation is (maybe) correct.

Consider how an application layer (e.g. smpclient) may interact with the types but prioritize correctness with the spec and Zephyr implementation. https://github.com/intercreate/smpclient/blob/4942251bf4256643fd8878641aa08519a6693d9b/smpclient/generics.py#L17-L28

Would be a good opportunity to change V0 and V1 to V1 and V2 - this will be a breaking change - better now than never!

@JPHutchins JPHutchins added the bug Something isn't working label Feb 12, 2024
@JPHutchins
Copy link
Owner Author

Chose V0 and V1 because it matches the enums provided. The spec calls for 0 = Version 1 and 1 = Version 2 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant