Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open Inventory bags #1939

Open
Seann1911 opened this issue Aug 27, 2024 · 7 comments
Open

Unable to open Inventory bags #1939

Seann1911 opened this issue Aug 27, 2024 · 7 comments

Comments

@Seann1911
Copy link

Which software were you running?

  • Addon version name: Bagnon 11.0.8
  • Client used: Retail 11.0.2

Have you read the changelog?
Yes

Please describe the bug.
Unable to open Inventory bags, bank bags open

Please describe how to reproduce it.

  1. try to open any inventory bag, except bank

Any Screenshots?

image

Error Logs are Important!

Message: ...terface/AddOns/BagBrother/core/classes/itemGroup.lua:112: attempt to compare number with boolean
Time: Mon Aug 26 17:38:45 2024
Count: 1
Stack: ...terface/AddOns/BagBrother/core/classes/itemGroup.lua:112: attempt to compare number with boolean
[string "@Interface/AddOns/BagBrother/core/classes/itemGroup.lua"]:112: in function Layout' [string "@Interface/AddOns/BagBrother/core/classes/itemGroup.lua"]:32: in function Update'
[string "@Interface/AddOns/BagBrother/core/classes/itemGroup.lua"]:26: in function <...terface/AddOns/BagBrother/core/classes/itemGroup.lua:12>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/Bagnon/src/frame.lua"]:24: in function New' [string "@Interface/AddOns/BagBrother/core/api/frames.lua"]:83: in function New'
[string "@Interface/AddOns/BagBrother/core/core.lua"]:54: in function <Interface/AddOns/BagBrother/core/core.lua:54>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdvancedInterfaceOptions/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...ons/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Interface/AddOns/AdvancedInterfaceOptions/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@Interface/AddOns/BagBrother/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...AddOns/BagBrother/libs/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals: self = Frame {
buttons =

{
}
order =
{
}
frame = BagnonInventory1 {
}
bags =
{
}
}
profile =
{
enabled = true
rules =
{
}
point = "BOTTOMRIGHT"
hiddenBags =
{
}
color =
{
}
hiddenRules =
{
}
y = 418.055908
x = -151.947632
borderColor =
{
}
lockedSlots =
{
}
reverseBags = false
bagBreak = false
}
columns = 10
scale = 1
size = 39
space = 1.300000
revBags = false
revSlots = nil
x = 10
y = 1
group = 0
(for index) = 2
(for limit) = 6
(for step) = 1
k = 2
frame = Frame {
id = 1
}
bag = 1
numSlots = 32
family = 0
slots =
{
}
(*temporary) = false
(*temporary) = 0
(*temporary) = 2
(*temporary) = 23
(*temporary) = 0
(*temporary) = 0
(*temporary) = 23
(*temporary) = 0
(*temporary) = "owner"
(*temporary) = nil
(*temporary) = nil
(*temporary) =
{
__super =
{
}
__base =
{
}
BagGroup =
{
}
OpenSound = 862
__frames =
{
}
__type = "Frame"
__count = 0
FontH = GameFontHighlightLeft {
}
BrokerSpacing = 2
__name = "BagnonFrame"
MoneyFrame =
{
}
MoneySpacing = 8
CloseSound = 863
Font = GameFontNormalLeft {
}
__index =
{
}
}
(*temporary) = "owner"
(*temporary) = "attempt to compare number with boolean"

Message: Interface/AddOns/BagBrother/config/panels/frame.lua:100: attempt to compare number with boolean
Time: Mon Aug 26 17:39:20 2024
Count: 1
Stack: Interface/AddOns/BagBrother/config/panels/frame.lua:100: attempt to compare number with boolean
[string "@Interface/AddOns/BagBrother/config/panels/frame.lua"]:100: in function <Interface/AddOns/BagBrother/config/panels/frame.lua:64>
[string "@Interface/AddOns/BagBrother/config/classes/optionsPanel.lua"]:26: in function method' [string "@Interface/AddOns/BagBrother/libs/Sushi-3.2/classes/core/Callable.lua"]:59: in function <.../BagBrother/libs/Sushi-3.2/classes/core/Callable.lua:55> [string "@Interface/AddOns/BagBrother/libs/Sushi-3.2/Sushi-3.2.lua"]:28: in function FireCalls'
[string "@Interface/AddOns/BagBrother/libs/Sushi-3.2/classes/groups/Group.lua"]:71: in function UpdateChildren' [string "@Interface/AddOns/BagBrother/libs/Sushi-3.2/classes/groups/Group.lua"]:65: in function <...s/BagBrother/libs/Sushi-3.2/classes/groups/Group.lua:63> [string "@Interface/AddOns/BagBrother/libs/Sushi-3.2/Sushi-3.2.lua"]:28: in function SetChildren'
[string "@Interface/AddOns/BagBrother/config/classes/optionsPanel.lua"]:26: in function AddRow' [string "@Interface/AddOns/BagBrother/config/panels/frame.lua"]:64: in function Populate'
[string "@Interface/AddOns/BagBrother/config/classes/optionsPanel.lua"]:17: in function method' [string "@Interface/AddOns/BagBrother/libs/Sushi-3.2/classes/core/Callable.lua"]:59: in function <.../BagBrother/libs/Sushi-3.2/classes/core/Callable.lua:55> [string "@Interface/AddOns/BagBrother/libs/Sushi-3.2/Sushi-3.2.lua"]:28: in function FireCalls'
[string "@Interface/AddOns/BagBrother/libs/Sushi-3.2/classes/groups/Group.lua"]:71: in function <...s/BagBrother/libs/Sushi-3.2/classes/groups/Group.lua:68>
[string "=[C]"]: in function Show' [string "@Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua"]:866: in function DisplayLayout'
[string "@Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua"]:807: in function DisplayCategory' [string "@Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua"]:749: in function <.../Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua:742> [string "=[C]"]: ? [string "@Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua"]:144: in function <...e/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:143> [string "=[C]"]: ? [string "@Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua"]:147: in function TriggerEvent'
[string "@Interface/AddOns/Blizzard_Settings_Shared/Blizzard_CategoryList.lua"]:152: in function <...s/Blizzard_Settings_Shared/Blizzard_CategoryList.lua:150>

Locals: (*temporary) = false
(*temporary) = Frame {
limit = false
calls =

{
}
Children =
{
}
row = Frame {
}
subtitle = "These are configuration settings specific to a Bagnon frame."
sets =
{
}
title = "Frame Settings |A:Vehicle-HammerGold-2:0:0:0:0|a"
Footer = FontString {
}
frame = "inventory"
Tag = "BAGNON_"
}
(*temporary) =
{
1 =
{
}
2 =
{
}
3 =
{
}
arg = "bagBreak"
}
(*temporary) = Sushi-3.2-DropChoice4 {
Label = FontString {
}
Right = Sushi-3.2-DropChoice4Right {
}
Left = Sushi-3.2-DropChoice4Left {
}
Text = Sushi-3.2-DropChoice4Text {
}
choices =
{
}
value = false
calls =
{
}
Button = Sushi-3.2-DropChoice4Button {
}
Icon = Sushi-3.2-DropChoice4Icon {
}
Middle = Sushi-3.2-DropChoice4Middle {
}
}
(*temporary) = Sushi-3.2-DropChoice4 {
Label = FontString {
}
Right = Sushi-3.2-DropChoice4Right {
}
Left = Sushi-3.2-DropChoice4Left {
}
Text = Sushi-3.2-DropChoice4Text {
}
choices =
{
}
value = false
calls =
{
}
Button = Sushi-3.2-DropChoice4Button {
}
Icon = Sushi-3.2-DropChoice4Icon {
}
Middle = Sushi-3.2-DropChoice4Middle {
}
}
(*temporary) =
{
1 =
{
}
2 =
{
}
3 =
{
}
arg = "bagBreak"
}
(*temporary) = nil
(*temporary) = "attempt to compare

Message: .../AddOns/BagBrother/core/features/updateDetection.lua:49: attempt to index local 'latest' (a nil value)
Time: Mon Aug 26 17:49:14 2024
Count: 1
Stack: .../AddOns/BagBrother/core/features/updateDetection.lua:49: attempt to index local 'latest' (a nil value)
[string "@Interface/AddOns/BagBrother/core/features/updateDetection.lua"]:49: in function ?' [string "@Interface/AddOns/AdvancedInterfaceOptions/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:109: in function <...ons/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:109> [string "=[C]"]: ? [string "@Interface/AddOns/AdvancedInterfaceOptions/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...ons/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@Interface/AddOns/AdvancedInterfaceOptions/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function Fire'
[string "@Interface/AddOns/BagBrother/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...AddOns/BagBrother/libs/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals: self =

{
Queued =
{
}
Tag = "BAGNON_"
}
_ = "CHAT_MSG_ADDON"
prefix = "Bagnon"
version = "11.0.8"
channel = "GUILD"
sender = "Äcog-Tichondrius"
latest = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'latest' (a nil value)"
ADDON = "Bagnon"
Addon =
{
IsRetail = true
InventoryBags =
{
}
Currency =
{
}
Skins =
{
}
ItemGroup =
{
}
AccountMoney =
{
}
ContainerItemGroup =
{
}
BankTab =
{
}
Frame =
{
}
OptionsToggle =
{
}
Bag =
{
}
CurrencyTooltipCounts =
{
}
Base =
{
}
sets =
{
}
Name = "Bagnon"
guild =
{
}
Parented =
{
}
player =
{
}
ItemSlot =
{
}
SearchToggle =
{
}
Cacher =
{
}
NumBags = 5
ReagentButton =
{
}
SearchFrame =
{
}
Item =
{
}
IsClassic = false
BankBags =
{
}
Title =
{
}
Slash = "bgn"
OwnerSelector =
{
}
SideFilters =
{
}
Commands =
{
}
Sorting =
{
}
SortButton =
{
}
LastBankTab = 17
BrokerCarrousel =
{
}
ContainerItem =
{
}
BagToggle =
{
}
BagGroup =
{
}
Events =
{
}
LDB =
{
}
TooltipCounts =
{
}
AutoDisplay =
{
}
LastBankBag = 12
Tag = "BAGNON_"
Inventory =
{
}
CurrencyTracker =
{
}
DropButton =
{
}
Owners =
{
}
Settings =
{
}
Bank =
{
}
Rules =
{
}
Frames =
{
}
MoneyFrame =
{
}
Tipped =
{
}
UpdateDetection =
{
}
CurrencyLimit = 30
None =
{
}
Version = "11.0.8"
}
nextExpansion = 130000

@Trollagerale
Copy link

Also having this issue

@Mekilya
Copy link

Mekilya commented Aug 28, 2024

I can open my bags however Reagents are not going into the Reagent slot and If I have items already in the bank and attempt to put same item from my inventory bag into the bank it will not put it with the item it puts the item in another open slot forcing me to manually add said item

@pmgower
Copy link

pmgower commented Aug 30, 2024

I have a solution that keeps the error from happening but I'm not sure if it's a true fix as I'm not familiar with this code base.

I changed line 112 of [your_wow_folder]\_retail_\Interface\AddOns\BagBrother\core\classes\itemGroup.lua to this:
`if x > 0 and (profile.bagBreak and family ~= group and family * group <= 0) then`

I have opened an MR to add this fix and assuming @Jaliborc doesn't see any issues with it this will hopefully be released soon.

@nathund
Copy link

nathund commented Aug 30, 2024 via email

@Trollagerale
Copy link

I have a solution that keeps the error from happening but I'm not sure if it's a true fix as I'm not familiar with this code base.

I changed line 112 of [your_wow_folder]_retail_\Interface\AddOns\BagBrother\core\classes\itemGroup.lua to this: if x > 0 and (profile.bagBreak and family ~= group and family * group <= 0) then

I have opened an MR to add this fix and assuming @Jaliborc doesn't see any issues with it this will hopefully be released soon.

This solution worked for me. Thanks!
Notepad++ can be used to make this change easily for others having this issue.

@Seann1911
Copy link
Author

I have a solution that keeps the error from happening but I'm not sure if it's a true fix as I'm not familiar with this code base.

I changed line 112 of [your_wow_folder]_retail_\Interface\AddOns\BagBrother\core\classes\itemGroup.lua to this: if x > 0 and (profile.bagBreak and family ~= group and family * group <= 0) then

I have opened an MR to add this fix and assuming @Jaliborc doesn't see any issues with it this will hopefully be released soon.

Thank you! This solved my issue.

@gianlucazigni
Copy link

I seemed to have luck by removing the addon , deleting the savedvariable files in the WTF folder for Bagnon and BagBrother, then reinstalling the addon. the bagBreak variable is indeed now an intenger as the settings indicates a drop down with three options indexed 0-2 which means that deleting this check for bagBreak only disables the functionality of splitting the bags. From what i can tell this used to be a boolean and for some reason the saved variable file refuses to update to the new default of 0 unless a full clean install is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants