From 1fb3f919d32ff086e2e1115880de1b0ae0d53e74 Mon Sep 17 00:00:00 2001
From: Simon Cropp <simon.cropp@gmail.com>
Date: Sun, 7 Apr 2024 20:28:48 +1000
Subject: [PATCH] move shared settings to Directory.Build.props

---
 src/Alba.sln                                         | 5 +++++
 src/Alba/Alba.csproj                                 | 2 --
 src/Directory.Build.props                            | 3 +++
 src/IdentityServer.New/IdentityServer.New.csproj     | 1 -
 src/MinimalApiWithOakton/MinimalApiWithOakton.csproj | 2 --
 src/WebApiNet6/WebApiNet6.csproj                     | 2 --
 6 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/Alba.sln b/src/Alba.sln
index 6fcbff59..e11e7507 100644
--- a/src/Alba.sln
+++ b/src/Alba.sln
@@ -22,6 +22,11 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "IdentityServer.New", "Ident
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "_build", "..\build\_build.csproj", "{2D104BF1-7D1F-4DFF-9023-AEDF73C34B67}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".SolutionItems", ".SolutionItems", "{8B852484-20CA-450C-8DDA-E1F9CE84C28D}"
+	ProjectSection(SolutionItems) = preProject
+		Directory.Build.props = Directory.Build.props
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
diff --git a/src/Alba/Alba.csproj b/src/Alba/Alba.csproj
index 54ae92d5..693e7362 100644
--- a/src/Alba/Alba.csproj
+++ b/src/Alba/Alba.csproj
@@ -10,8 +10,6 @@
     <RepositoryUrl>git://github.com/JasperFx/alba</RepositoryUrl>
     <OutputType>library</OutputType>
     <PackageIconUrl>https://avatars2.githubusercontent.com/u/10048186?v=3&amp;s=200</PackageIconUrl>
-    <langversion>10</langversion>
-    <nullable>enable</nullable>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <NoWarn>CS1591;</NoWarn>
   </PropertyGroup>
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index cfdeba69..85fac8e7 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project>
     <PropertyGroup>
+        <LangVersion>12</LangVersion>
+        <Nullable>enable</Nullable>
+        <ImplicitUsings>enable</ImplicitUsings>
         <WarningsAsErrors>NU1901;NU1902;NU1903;NU1904</WarningsAsErrors>
         <NuGetAuditMode>all</NuGetAuditMode>
         <NuGetAuditLevel>low</NuGetAuditLevel>
diff --git a/src/IdentityServer.New/IdentityServer.New.csproj b/src/IdentityServer.New/IdentityServer.New.csproj
index ab43d217..878be983 100644
--- a/src/IdentityServer.New/IdentityServer.New.csproj
+++ b/src/IdentityServer.New/IdentityServer.New.csproj
@@ -2,7 +2,6 @@
 
 	<PropertyGroup>
 		<TargetFramework>net6.0</TargetFramework>
-		<ImplicitUsings>enable</ImplicitUsings>
 	</PropertyGroup>
 
 	<ItemGroup>
diff --git a/src/MinimalApiWithOakton/MinimalApiWithOakton.csproj b/src/MinimalApiWithOakton/MinimalApiWithOakton.csproj
index f644da1b..cfd0c6ce 100644
--- a/src/MinimalApiWithOakton/MinimalApiWithOakton.csproj
+++ b/src/MinimalApiWithOakton/MinimalApiWithOakton.csproj
@@ -2,8 +2,6 @@
 
     <PropertyGroup>
         <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
-        <Nullable>enable</Nullable>
-        <ImplicitUsings>enable</ImplicitUsings>
     </PropertyGroup>
 
     <ItemGroup>
diff --git a/src/WebApiNet6/WebApiNet6.csproj b/src/WebApiNet6/WebApiNet6.csproj
index 493a6f7f..fbd67740 100644
--- a/src/WebApiNet6/WebApiNet6.csproj
+++ b/src/WebApiNet6/WebApiNet6.csproj
@@ -2,8 +2,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
-    <Nullable>enable</Nullable>
-    <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 
   <ItemGroup>