rewind crashes instantly on macOS ARM with JIT enabled

[warmenhoven]

What version of melonDS DS are you using?

35294b8

Does the problem happen in standalone melonDS?

I don't know.

What happened?

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   melondsds_libretro.dylib      	       0x129143718 melonDS::ARMJIT::ResetBlockCache() + 1116
1   melondsds_libretro.dylib      	       0x129105b38 melonDS::NDS::DoSavestate(melonDS::Savestate*) + 3736
2   melondsds_libretro.dylib      	       0x129013db0 MelonDsDs::CoreState::Unserialize(nonstd::span_lite::span<std::byte const, 18446744073709551615ul>) + 328
3   melondsds_libretro.dylib      	       0x129021168 retro_unserialize + 92
4   RetroArch                     	       0x100ba0538 core_unserialize + 76 (runloop.c:7662)
5   RetroArch                     	       0x100e54114 content_load_rastate1 + 488 (task_save.c:1166)
6   RetroArch                     	       0x100c1a7d4 content_deserialize_state + 204 (task_save.c:1255)
7   RetroArch                     	       0x100c1a33c state_manager_check_rewind + 632 (state_manager.c:766)
8   RetroArch                     	       0x100c4889c runloop_check_state + 8900 (runloop.c:6139)
9   RetroArch                     	       0x100c4569c runloop_iterate + 1340 (runloop.c:6917)

What should've happened instead?

Rewinds fine; with JIT disabled it works.

Which platforms do you see the problem on?

• Windows
• macOS
• Linux
• Android
• iOS
• tvOS
• Other (specify below)

Which versions of the OS?

macOS 14.2.1 Apple M2 Ultra

Which libretro frontend are you using?

Retroarch lastest master

Terms

• I agree to follow the code of conduct.
• I understand that melonDS DS is not developed or maintained by the authors of melonDS.
• I understand that this form is for reporting bugs, not for requesting help.
• I understand that the author develops this core in his spare time, and that he is under no obligation to respond to this bug report.

[JesseTG]

I cannot reproduce this on my x64 Mac, so the issue may be ARM-specific. Unfortunately I don't own an ARM Mac, so I'm gonna need help to fix and test this.

[warmenhoven]

melonDS-emu/melonDS#1937

[JesseTG]

Closed, since that upstream PR has been integrated.