Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compose ktlint rules, fix issues #431

Open
rock3r opened this issue Jul 4, 2024 · 3 comments · May be fixed by #712
Open

Add compose ktlint rules, fix issues #431

rock3r opened this issue Jul 4, 2024 · 3 comments · May be fixed by #712
Assignees
Labels
maintenance Rote maintenance tasks (e.g., dependency updates)

Comments

@rock3r
Copy link
Collaborator

rock3r commented Jul 4, 2024

We need to add the ktlint Compose ruleset as things are slipping through Detect. We also have to address new warnings that come up with the new ruleset.

@rock3r rock3r added the maintenance Rote maintenance tasks (e.g., dependency updates) label Jul 4, 2024
@hamen hamen added in-progress This issue is being worked on blocked-externally This issue or feature is blocked by external dependencies (e.g., bugs in Compose) and removed in-progress This issue is being worked on labels Jul 8, 2024
@hamen
Copy link
Collaborator

hamen commented Jul 9, 2024

We will monitor Spotless releases until they include the fix for ktfmt we need 🤞

@rock3r
Copy link
Collaborator Author

rock3r commented Jul 19, 2024

Notes on this:

  • We want to use ktfmt for formatting because it's more deterministic
  • We still want to keep ktlint for warnings and checks — same as detekt
  • We want to include the Compose ktlint ruleset, too
  • We need to test drive the IJ plugin (Spotless Gradle) to handle formatting properly
    • We should look into Spotless Applier, too, because it seems more flexible and has more features. It's also actively maintained, contrary to Spotless Gradle.

@rock3r
Copy link
Collaborator Author

rock3r commented Jul 23, 2024

More notes: we should consider straight-up ktfmt for formatting, and maybe forking the ktlint plugin to fix its useless, constant nags, and properly support external rulesets.

@rock3r rock3r linked a pull request Dec 10, 2024 that will close this issue
@rock3r rock3r assigned rock3r and unassigned hamen Dec 10, 2024
@rock3r rock3r removed the blocked-externally This issue or feature is blocked by external dependencies (e.g., bugs in Compose) label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Rote maintenance tasks (e.g., dependency updates)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants