Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate Errors when catching exceptions in Lincheck #258

Open
ndkoval opened this issue Jan 18, 2024 · 0 comments
Open

Propagate Errors when catching exceptions in Lincheck #258

ndkoval opened this issue Jan 18, 2024 · 0 comments

Comments

@ndkoval
Copy link
Collaborator

ndkoval commented Jan 18, 2024 •
edited
Loading

As pointed in #130 (here), Lincheck swallows all throwable exceptions blindly, whereas Error types should always be propagated and never handled directly. This results in the test retrying forever and not reporting what went wrong.

Let's always propagate Errors.
@ndkoval ndkoval mentioned this issue Jan 18, 2024
Closed
@ndkoval ndkoval changed the title Propagate Errors when catching exceptions Propagate Linchek's Errors when catching exceptions Oct 17, 2024
@ndkoval ndkoval changed the title Propagate Linchek's Errors when catching exceptions Propagate Errors when catching exceptions in Lincheck Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndkoval