Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] gossip selection doesn't work as intended #86

Closed
Bia10 opened this issue Sep 15, 2021 · 1 comment
Closed

[Bug] gossip selection doesn't work as intended #86

Bia10 opened this issue Sep 15, 2021 · 1 comment

Comments

@Bia10
Copy link
Contributor

Bia10 commented Sep 15, 2021

Been experimenting with trainer gossip and here's something fishy i did not get to bottom of:

Once you have gossip frame open with trainer following scenarios unfold:

  1. Bot.Wow.SelectGossipOptionSimple(1);

which calls:

public void SelectGossipOptionSimple(int gossipId)
{
  LuaDoString($"SelectGossipOption({gossipId}))");
}

result: does nothing

  1. Bot.Wow.SelectGossipOption(1);

which calls:

public void SelectGossipOption(int gossipId)
{
  LuaDoString($"SelectGossipOption(max({gossipId}, GetNumGossipOptions()))");
}

result: unlearn talents frame opens

  1. Using dev-tools and calling LuaDoString with "SelectGossipOption(1)"

result: learn skills frame opens

So the question is how are the case 1 and 3 different? if they lead to such drastically different results.

@Bia10
Copy link
Contributor Author

Bia10 commented Sep 15, 2021

mystery solved there's an extra brace ) in SelectGossipOptionSimple()

@Bia10 Bia10 closed this as completed Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant