-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module error when trying to include #5
Comments
Ah hmm, so the built version has the styles included in the javascript, but the source version uses stylus-loader to compile that shiz. Is there a stylus-loader equivalent for gobble? |
Looks like maybe it's the hot-loader code at L437: if(!content.placeholders) {
module.hot.accept("!!./../node_modules/css-loader/index.js!./../node_modules/stylus-loader/index.js!./styles.styl", function() {
var newContent = require("!!./../node_modules/css-loader/index.js!./../node_modules/stylus-loader/index.js!./styles.styl");
if(typeof newContent === 'string') newContent = [[module.id, newContent, '']];
update(newContent);
});
} |
@martypdx I've been making a lot of components lately and I want them to be usable for everyone. Would it be easier if I pointed the package.main towards the built version? Or do you use the version in src/ directly? Also, I may be able to run it through Uglify and then beautify it so it removes all the useless webpack before it goes through uglify again in your app. |
The other option is to do what I did in ractive-autosize-input and only provide a minified version in the repo and leave the package.json's |
@JonDum I just did The package main looks like it is pointed to |
That's the goal! But I actually meant for src/datatable.js to be the package main lol. What do you use? Gulp+Babel? I'd like to test if it works when package.main points to the src/ entry file. |
gobble + gobble-babel + browerify |
Can you post your gobblefile you use? I used the example project in the gobble repo, and all it did was output some app.js pre-gobble:
post gobble:
Not sure how the imports/requires even get into the resultant app.js? The build folder doesn't even include them anywhere. |
I have installed version : "ractive-datatable": "^1.7.0" After including this line the following throwing ....
|
Can't require this because inclusion of require('styles.styl') doesn't work (I'm not using webpack).
Doesn't seem like dev dependencies should be necessary for runtime use :)
The text was updated successfully, but these errors were encountered: