Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is a patch to original sff_extract implementation still applicable to current code? #14

Open
mmokrejs opened this issue Jul 30, 2017 · 0 comments

Comments

@mmokrejs
Copy link

Hi,
in the past I found an error in sff_extract distributed through mira_3rdparty_06-07-2012.tar.bz2 , see https://www.freelists.org/post/mira_talk/sff-extract-fix-broken-handling-of-overlapped-trim-points-leaking-adapters-into-supposedly-clean-output .

The code in seq_crumbs is rewritten a lot but I wonder whether you would like to check whether the logic contain the same bug or not. Here is the patch:
sff_extract.patch.txt

There used to be bug in biopython around 1.62 to 1.64 exploited by overlapped trimpoints which made the slicing go wrong. Test your seq_crumbs-based sff_extract with biopython-1.65 or newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant