Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Tests: Fill in test coverage #6

Open
3 tasks done
JoshuaKGoldberg opened this issue Jan 19, 2025 · 1 comment
Open
3 tasks done

🧪 Tests: Fill in test coverage #6

JoshuaKGoldberg opened this issue Jan 19, 2025 · 1 comment
Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jan 19, 2025 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

6bf5c33 added in initial functionality for removeArrayElement and removeObjectProperty. But it didn't add any tests. I was just trying it out with pnpm link --global against https://github.com/JoshuaKGoldberg/eslint-plugin-package-json.

Unit tests should definitely be added for these functions - once we resolve that we're happy with them in JoshuaKGoldberg/eslint-plugin-package-json#747 -> JoshuaKGoldberg/eslint-plugin-package-json#750.

Additional Info

https://github.com/JoshuaKGoldberg/ts-api-utils might be useful as a reference of tests for ESLint helpers.

💖
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance 🛠️ status: blocked Waiting for something else to be resolved 🙅 status: accepting prs Please, send a pull request to resolve this! 🙏 and removed status: blocked Waiting for something else to be resolved 🙅 labels Jan 19, 2025
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg/eslint-plugin-package-json#750 seems happy with them, just blocked on bundling shenanigans (#13). Marking this as accepting PRs.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 22, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg