Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dev dependencies to latest #33

Closed
Tracked by #28
JoshuaKGoldberg opened this issue Sep 13, 2023 · 2 comments · Fixed by #117
Closed
Tracked by #28

Bump dev dependencies to latest #33

JoshuaKGoldberg opened this issue Sep 13, 2023 · 2 comments · Fixed by #117
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Splitting out of #28: it's been a while since the package.json dependencies were updated. I'd like to get them all bumped to the latest.
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Sep 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 13, 2023
This was referenced Sep 13, 2023
Closed
Closed
Closed
@JoshuaKGoldberg
Copy link
Owner Author

Oh boy, file extension based processors are deprecated in ESLint now. https://eslint.org/docs/latest/extend/custom-processors#file-extension-named-processor -> #39.

@JoshuaKGoldberg JoshuaKGoldberg added status: blocked Waiting for something else to be resolved and removed status: accepting prs Please, send a pull request to resolve this! labels Sep 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 14, 2023
Merged
@kendallgassner kendallgassner mentioned this issue Oct 2, 2023
Merged
JoshuaKGoldberg added a commit that referenced this issue Oct 17, 2023
@kendallgassner @JoshuaKGoldberg
Update order-properties to use sort-package-json (#55)
6857660 
closes:
#31


### What

- Replaced the `order-properties` sorting algorithm to use
[sort-package-json](https://github.com/keithamus/sort-package-json).
- Changed the type of `options` from an `Array<string>` to 
```tsx
{
    order?: "legacy" | "sort-package-json" | Array<string>
}
```
- defaulted the sort order to `legacy`
- Add additional testing to test options: "legacy" | "sort-package-json"
.


### Callouts

#### Option: `order: Array<string>`

Previously, any property that was not provided in the `order:
Array<string>` collection was ignored by the sort algorithm. Now that we
are using `sort-package-json`, [a property that is not provided in the
`order: Array<string>` will be sorted by the `defaultSortOrder` provided
by the
library.](https://github.com/keithamus/sort-package-json#optionssortorder)

#### Sort-package-json version
the latest version of sort-package-json is [an esm
module](https://github.com/keithamus/sort-package-json/blob/main/package.json#L20)
so I opted to use an earlier version to avoid heavy refactorign. This
package can be bumped when #33 is merged.

---------

Co-authored-by: Josh Goldberg <[email protected]>
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: blocked Waiting for something else to be resolved labels Jan 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title Bump dependencies to latest Bump dev dependencies to latest Jan 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 20, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 20, 2024
@JoshuaKGoldberg
chore: bump all dev dependencies (#117)
f5817ba 
## PR Checklist

-   [x] Addresses an existing open issue: fixes #33
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Uses `ncu -u` on all the `devDependencies` in the `package.json`.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.6.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump all dev dependencies JoshuaKGoldberg/eslint-plugin-package-json
1 participant
@JoshuaKGoldberg