Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Documentation: Do I need to install jsonc-eslint-parser? #601

Closed
2 tasks done
rakleed opened this issue Nov 2, 2024 · 2 comments
Closed
2 tasks done

📝 Documentation: Do I need to install jsonc-eslint-parser? #601

rakleed opened this issue Nov 2, 2024 · 2 comments
Labels
area: documentation Improvements or additions to docs good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!

Comments

@rakleed
Copy link
Contributor

rakleed commented Nov 2, 2024

Bug Report Checklist

Overview

I removed jsonc-eslint-parser, but ESLint still reports errors in package.json and applies autofixes. Do I really need to install jsonc-eslint-parser?

And isn't it better to use @eslint/json for flat config, if it is still needed in some cases?

Additional Info

No response

@rakleed rakleed added the area: documentation Improvements or additions to docs label Nov 2, 2024
@JoshuaKGoldberg
Copy link
Owner

👋 Good questions, thanks for posting!

Do I really need to install jsonc-eslint-parser?

No, that isn't necessary in flat config. I think this is a bug in the docs - the installation command for Flat Config shouldn't include jsonc-eslint-parser. Accepting PRs to make separate installation commands for flat & legacy config in the README.md.

And isn't it better to use @eslint/json for flat config, if it is still needed in some cases?

I'm in favor of doing some research there, but don't have the time myself. Also mentioned here: #42 (comment). If you want to file a new issue & post some initial findings/suggestions, that'd be great, yes please!

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! labels Nov 4, 2024
@JoshuaKGoldberg
Copy link
Owner

Fixed by #654.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Improvements or additions to docs good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Development

No branches or pull requests

2 participants