You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following #42 -> #51: we've resolved to create a standalone valid-type rule. It should enforce that, if the field exists in the package.json file, it's set to a valid value. It should do nothing if the field doesn't exist.
Additional Info
Per discussion in #51, this won't be enabled by default at first. The valid-package-def rule already contains this logic using package-json-validator. For this issue, we should:
Send a PR to create the rule in this repo (resolving this issue)
Once a version of package-json-validator is released with that feature, file an issue on this repo to switch the rule to use that API from package-json-validator
If you want to take on just step 1, that's ok - no pressure to do all three. 🙂
Once allvalid- rules exist in this plugin, we can then file an issue to deprecate the valid-package-def rule in favor of them.
💖
The text was updated successfully, but these errors were encountered:
Note: michaelfaith and I talked over the strategy. I'd initially put that the validation API should exist in package-json-validator first, then be ported here. Michael suggested letting folks make it here first for an easier contribution process and faster determining whether how the API should look the rule. I agree, that's much better 😄. Edited.
Bug Report Checklist
main
branch of the repository.Overview
Following #42 -> #51: we've resolved to create a standalone
valid-type
rule. It should enforce that, if the field exists in thepackage.json
file, it's set to a valid value. It should do nothing if the field doesn't exist.Additional Info
Per discussion in #51, this won't be enabled by default at first. The
valid-package-def
rule already contains this logic usingpackage-json-validator
. For this issue, we should:package-json-validator
is released with that feature, file an issue on this repo to switch the rule to use that API frompackage-json-validator
If you want to take on just step 1, that's ok - no pressure to do all three. 🙂
Once all
valid-
rules exist in this plugin, we can then file an issue to deprecate thevalid-package-def
rule in favor of them.💖
The text was updated successfully, but these errors were encountered: