Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: incorporate publint rules #85

Open
Zamiell opened this issue Dec 14, 2023 · 4 comments
Open

🚀 Feature: incorporate publint rules #85

Zamiell opened this issue Dec 14, 2023 · 4 comments
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request

Comments

@Zamiell
Copy link
Contributor

Zamiell commented Dec 14, 2023

It would be nice if this plugin incorporated the rules from publint: https://publint.dev/rules

@Zamiell Zamiell added the type: feature New enhancement or request label Dec 14, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the status: in discussion Not yet ready for implementation or a pull request label Dec 15, 2023
@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 15, 2023

Agreed! I think a good next step would be to add publint to the table in #42 to see what isn't partially or fully duplicated in that table. Once that's done we can file issues for granular rules.

If you have time, that'd be fantastic. Otherwise I'll get to it... eventually 😅.

Edit (Jan 2024): to be clear, I'm suggesting posting here with a description of what new rule might be added. I can merge that into the table if they all look good.

@michaelfaith
Copy link
Collaborator

@Zamiell are you still interested in some subset of those rules being considered for this plugin?

@Zamiell
Copy link
Contributor Author

Zamiell commented Jan 25, 2025

i think it would be nice to have these rules in eslint land to prevent people from having to use more than one tool to lint.
with that said, i personally don't currently use eslint-plugin-package-json in favor of prettier-plugin-packagejson.

@michaelfaith
Copy link
Collaborator

Sounds good. If you have the time, as Josh mentioned here #85 (comment), if you have any recommendations for specific rules that you think would be a good fit, we could add it to the tracking table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

3 participants