Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: LoadError: UndefVarError: installed not defined #12

Open
zsz00 opened this issue Oct 24, 2019 · 8 comments
Open

ERROR: LoadError: UndefVarError: installed not defined #12

zsz00 opened this issue Oct 24, 2019 · 8 comments

Comments

@zsz00
Copy link

zsz00 commented Oct 24, 2019

Julia Version 1.4.0-DEV.254
Commit 3b1c1fdde3 (2019-10-04 01:47 UTC)
Platform Info:
OS: Windows (x86_64-w64-mingw32)
CPU: Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-6.0.1 (ORCJIT, skylake)

using Py2Jl

ERROR: LoadError: LoadError: LoadError: UndefVarError: installed not defined
Stacktrace:
[1] getproperty(::Module, ::Symbol) at .\Base.jl:26
[2] top-level scope at C:\Users\zsz.julia\packages\Py2Jl\H6uW5\src\ASTGen.jl:13
[3] eval(::Module, ::Any) at .\boot.jl:330
....

@thautwarm
Copy link
Member

Sorry. You should ping me...

@thautwarm
Copy link
Member

Did Pkg change it API in 1.4?

@visr
Copy link

visr commented Feb 23, 2020

Pkg.installed is deprecated in 1.4, yes.

I'm not sure I understand the compat_32842 code. Why do we check if MLStyle is installed if it is in the dependencies? Can't we just require a sufficiently new MLStyle version?

@thautwarm
Copy link
Member

@visr You could just ask me the functionality because this is quite a tricky workaround.

It's exactly a workaround for JuliaLang/julia#32842 .

To solve this, a quick fix is transforming all string literal pattern like "xxx" to pattern &"xxx", where the former is matched by === comparisons, and the latter is matched by == comparisons.

@visr
Copy link

visr commented Feb 23, 2020

I see. Would it be an option to stop supporting the julia versions where this is broken?

@thautwarm
Copy link
Member

@visr I don't think it an appealing idea. We can make a tag for previously supported versions. And remove compat_32842 stuffs and poblish things since new Julia versions.

@thautwarm
Copy link
Member

I'll do it later, but this is actually not in a high priority.

If you want I can give your help for trying maintaining it.
We could talk in Slack(search thautwarm/Taine Zhao in Julia Slack), and I can answer you any trivial or non-trivial questions about this package.

@visr
Copy link

visr commented Feb 23, 2020

Thanks! This issue just gives a deprecation warning on julia 1.4-rc. It was submitted during 1.4-dev, probably before the deprecation was in place, giving a hard error.

thautwarm added a commit that referenced this issue Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants