Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducing over an empty collection is not allowed; consider supplying init to the reducer #87

Open
kafisatz opened this issue May 4, 2023 · 1 comment

Comments

@kafisatz
Copy link

kafisatz commented May 4, 2023

I have a date vector (originally from CSV.read) on which extrema fails, see below
Interestingly when I copy the data, things work. I.e. extrema(dd[1:end]) works

below is an MWE.

julia> using Dates

julia> using DataFrames

julia> using CSV

julia> #p = CSV.read(raw"C:\temp\ori2c.csv",DataFrame,dateformat="dd.mm.yyyy",copycols=true,stringtype=String,pool=false);

julia> fi = raw"https://gist.githubusercontent.com/kafisatz/e64a61727d8817a4433cecf17144dd55/raw/f49241d0d6b177c10d23809750b1c7af21f53adf/ori2c.csv";

julia> p = CSV.read(download(fi),DataFrame,dateformat="dd.mm.yyyy",copycols=true,stringtype=String,pool=false);

julia> addtldf=DataFrame(a=String[],date=Date[],b=Int[],c=Int[],date2=Date[]);

julia> append!(p,addtldf);

julia> extrema(p.date)
ERROR: MethodError: reducing over an empty collection is not allowed; consider supplying `init` to the reducer
Stacktrace:
  [1] reduce_empty(op::Base.MappingRF{Base.ExtremaMap{typeof(identity)}, typeof(Base._extrema_rf)}, #unused#::Type{Date})
    @ Base .\reduce.jl:356
  [2] reduce_empty_iter
    @ .\reduce.jl:379 [inlined]
  [3] mapreduce_empty_iter(f::Function, op::Function, itr::Vector{Date}, ItrEltype::Base.HasEltype)
    @ Base .\reduce.jl:375
  [4] _mapreduce
    @ .\reduce.jl:427 [inlined]
  [5] _mapreduce_dim
    @ .\reducedim.jl:365 [inlined]
  [6] #mapreduce#765
    @ .\reducedim.jl:357 [inlined]
  [7] mapreduce
    @ .\reducedim.jl:357 [inlined]
  [8] #_extrema#791
    @ .\reducedim.jl:999 [inlined]
  [9] _extrema
    @ .\reducedim.jl:999 [inlined]
 [10] #extrema#789
    @ .\reducedim.jl:995 [inlined]
 [11] extrema
    @ .\reducedim.jl:995 [inlined]
 [12] extrema
    @ C:\Users\bernhard.konig\.julia\packages\SentinelArrays\BcfVF\src\chainedvector.jl:793 [inlined]
 [13] extrema(x::SentinelArrays.ChainedVector{Date, Vector{Date}})
    @ SentinelArrays C:\Users\bernhard.konig\.julia\packages\SentinelArrays\BcfVF\src\chainedvector.jl:787
 [14] top-level scope
    @ REPL[9]:1

julia> extrema(p.date[1:end])
(Date("2023-02-01"), Date("2023-05-03"))

julia> versioninfo()
Julia Version 1.8.5
Commit 17cfb8e65e (2023-01-08 06:45 UTC)
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: 32 × AMD Ryzen 9 5950X 16-Core Processor
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 16 on 32 virtual cores
Environment:
  JULIA_NUM_THREADS = 16
  JULIA_EDITOR = "code"

julia> 


[a93c6f00] DataFrames v1.5.0    
[336ed68f] CSV v0.10.9  
[91c51154] SentinelArrays v1.3.18

ori2c.csv

@laborg
Copy link
Contributor

laborg commented Dec 25, 2024

I think this can be closed:

....
julia> extrema(p.date)
(Date("2023-02-01"), Date("2023-05-03"))

(@temp) pkg> st
Status `~/.julia/environments/temp/Project.toml`
  [336ed68f] CSV v0.10.15
  [a93c6f00] DataFrames v1.7.0
  [91c51154] SentinelArrays v1.4.8 `https://github.com/JuliaData/SentinelArrays.jl.git#main`

julia> versioninfo()
Julia Version 1.11.2
Commit 5e9a32e7af2 (2024-12-01 20:02 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 12 × Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, skylake)
Threads: 1 default, 0 interactive, 1 GC (on 12 virtual cores)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants