Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the feature of search sharing by adding query param to the search. Issue #2543 #2645

Closed
wants to merge 0 commits into from

Conversation

Rahban1
Copy link

@Rahban1 Rahban1 commented Mar 4, 2025

No description provided.

@Rahban1
Copy link
Author

Rahban1 commented Mar 4, 2025

I don't know what I am missing but I have ran prettier and pushed the code to github still it is failing ci/cd on prettier checks, what am I missing ???
Screenshot 2025-03-04 at 3 14 11 PM
sorry for the problem and thank you in advance for your answer

@fingolfin
Copy link
Contributor

You have added the directory node_modules including all of the prettier code into this PR.

You also reformatted the Julia code in src with something that's not runic.

And you added lots of files in test that should not be there.

All of this needs to be undone, before this PR can be properly reviewed -- right now your actual changes are hidden in a sea of unrelated changes :-(

@Rahban1
Copy link
Author

Rahban1 commented Mar 4, 2025

You have added the directory node_modules including all of the prettier code into this PR.

You also reformatted the Julia code in src with something that's not runic.

And you added lots of files in test that should not be there.

All of this needs to be undone, before this PR can be properly reviewed -- right now your actual changes are hidden in a sea of unrelated changes :-(

Thank you so much for your reply, I will fix the error and submit the pr again. Apologies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants