Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3D20 not working. #43

Open
carlomontec opened this issue Aug 16, 2018 · 7 comments
Open

C3D20 not working. #43

carlomontec opened this issue Aug 16, 2018 · 7 comments

Comments

@carlomontec
Copy link
Contributor

carlomontec commented Aug 16, 2018

Hello, I tested to read a mesh with C3D20 elements without success, having the error:

ERROR: LoadError: MethodError: no method matching element_has_type(::Type{Val{:C3D20}}) Closest candidates are: element_has_type(::Type{Val{:C3D4}}) at /home/monjaraz/.julia/packages/AbaqusReader/5egCd/src/parse_mesh.jl:8 element_has_type(::Type{Val{:C3D8}}) at /home/monjaraz/.julia/packages/AbaqusReader/5egCd/src/parse_mesh.jl:11 element_has_type(::Type{Val{:C3D10}}) at /home/monjaraz/.julia/packages/AbaqusReader/5egCd/src/parse_mesh.jl:14 ...

However, if I add the following line in parse_mesh.jl
element_has_type(::Type{Val{:C3D20}}) = :Hex20
seems to work.

I must add that I only use the mesh importer for my own code to extract data of elements and nodes, rather than for JuliaFEM. Therefore I dont know if it would break anything at JuliaFEM

Thanks!

@ahojukka5
Copy link
Member

Looks like a solution. Can you make PR with that?

@carlomontec
Copy link
Contributor Author

Sure thing, I just need to learn how to make a PR :) gonna figure it out this weekend

@ahojukka5
Copy link
Member

Any progress on this?

@carlomontec
Copy link
Contributor Author

I actually submitted the PR a few days after. It's already merged. Is it OK also to make another PR for some elements in CalculiX? I'm not sure they exist in Abaqus.

@ahojukka5
Copy link
Member

Hmm good question. Opinions, @TeroFrondelius ?

@ahojukka5
Copy link
Member

For example, what kind of elements. Maybe there are counterparts in ABAQUS.

@TeroFrondelius
Copy link
Member

Any development is a good development. Please add also tests if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants