Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should implement readbytes #28

Open
JeffBezanson opened this issue Jun 2, 2015 · 1 comment
Open

should implement readbytes #28

JeffBezanson opened this issue Jun 2, 2015 · 1 comment

Comments

@JeffBezanson
Copy link

I hereby apologize for the readall function. I think GZip should implement readbytes instead, and inherit readall(::IO) that just wraps the result of readbytes in a string.

@quinnj
Copy link
Member

quinnj commented May 9, 2019

Yeah, it should really implement readbytes! or even better would be readavailable; as-is, the only standard IO function implemented is read(::GZipStream, ::Type{UInt8}), which means the majority of cases where a GZipStream is used generically falls back to byte-by-byte IO, which is probably terrible for performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants