Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State space is not fully aligned with Julia iteration interface #9

Open
4 tasks
dylan-asmar opened this issue Feb 9, 2024 · 0 comments
Open
4 tasks

State space is not fully aligned with Julia iteration interface #9

dylan-asmar opened this issue Feb 9, 2024 · 0 comments

Comments

@dylan-asmar
Copy link
Member

dylan-asmar commented Feb 9, 2024 •
edited
Loading

The function state_from_index is implemented in states.jl. However, if we are following the conventions of the Julia iteration interface, we should extend Base.getindex.

Recommended functions to implement:

  • Base.getindex(pomdp::TagPOMDP, si::Int) to replace state_from_index
  • Base.getindex(pomdp::TagPOMDP, si_range::UnitRange{Int})
  • Base.firstidex(pomdp::TagPOMDP)
  • Base.lastindex(pomdp::TagPOMDP)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dylan-asmar